Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing node-fetch with axios to get proxy detection #1036

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Replacing node-fetch with axios to get proxy detection #1036

merged 3 commits into from
Oct 26, 2020

Conversation

munozemilio
Copy link
Member

Fixes #968

feich-ms
feich-ms approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@feich-ms feich-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Looks good to me.

@munozemilio munozemilio merged commit e06ad47 into main Oct 26, 2020
@munozemilio munozemilio deleted the emimunoz/axios-proxy branch October 26, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feich-ms feich-ms feich-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy settings are not universally respected
2 participants
@munozemilio @feich-ms