Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy settings are not universally respected #968

Closed
felixvanleeuwen opened this issue Sep 10, 2020 · 3 comments · Fixed by #1036
Closed

Proxy settings are not universally respected #968

felixvanleeuwen opened this issue Sep 10, 2020 · 3 comments · Fixed by #1036
Assignees
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete
Milestone

Comments

@felixvanleeuwen
Copy link

Versions

What CLI version are you using.
@microsoft/botframework-cli/4.11.0-dev.20200907.c063415
What Nodejs version are you using
win32-x64 node-v12.18.1
What command-line interpreters are you using
Powershell 6 (x64)
What OS are you using
Windows 10

Describe the bug

Give a clear and concise description of what the bug is.
Before each BF CLI command node tries to access registry.npmjs.org without being aware of proxy settings.
This retries for about a minute and then the command actually goes through in about 2-3 seconds.
We have a script that runs about 30-40 of these commands and it takes about 45 minutes to run it.
When a temporary exception is made for this address in our firewall the script takes about 3-4 minutes to run.

To Reproduce

Steps to reproduce the behavior:

  1. Get behind a corporate proxy;
  2. Get behind a corporate firewall;
  3. Configure Node to use the proxy;
  4. Set environment variables to use the proxy;
  5. Run any of the following commands:
  • bf luis:version:export
  • bf luis:version:import
  • bf luis:train:run
  • bf luis:application:publish
  • bf qnamaker:kb:export
  • bf qnamaker:kb:replace
  • bf luis:version:rename
  • bf luis:convert
  • bf luis:version:list
  1. Wait for about a minute for the command to complete;
  2. That was the bug.

Expected behavior

Give a clear and concise description of what you expected to happen.
Every request that the BF CLI (and its dependencies) makes respects proxy settings, whether environment or Node.

[bug]

@tsuwandy tsuwandy added customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team. labels Sep 14, 2020
@tdurnford tdurnford added the Bot Services Required for internal Azure reporting. Do not delete. Do not change color. label Sep 14, 2020
@munozemilio munozemilio self-assigned this Sep 14, 2020
@munozemilio
Copy link
Member

Hello @felixvanleeuwen, thanks for reporting this. We will asses and address this issue during the current sprint.

@munozemilio munozemilio added this to the R11 milestone Sep 15, 2020
@munozemilio munozemilio added the customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. label Sep 15, 2020
@felixvanleeuwen
Copy link
Author

felixvanleeuwen commented Oct 7, 2020

bf orchestrator:nlr:get is a major offender.
The command itself appears to not respect the proxy settings and fetches directly from aka.ms.

@cleemullins
Copy link
Contributor

Per @munozemilio this should land in R11.

@cleemullins cleemullins added Size: S The issue is simple and well understood, it will take a day or less to complete P1 Painful if we don't fix, won't block releasing Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants