Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<xstring>: Make char_traits::assign not start lifetime of elements #4613

Merged
merged 1 commit into from
Apr 26, 2024
Merged

<xstring>: Make char_traits::assign not start lifetime of elements #4613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions stl/inc/xstring
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,31 +161,15 @@ struct _Char_traits { // properties of a string or stream element
static _CONSTEXPR20 _Elem* assign(
_Out_writes_all_(_Count) _Elem* const _First, size_t _Count, const _Elem _Ch) noexcept /* strengthened */ {
// assign _Count * _Ch to [_First, ...)
#if _HAS_CXX20
if (_STD is_constant_evaluated()) {
for (_Elem* _Next = _First; _Count > 0; --_Count, ++_Next) {
_STD construct_at(_Next, _Ch);
}
} else
#endif // _HAS_CXX20
{
for (_Elem* _Next = _First; _Count > 0; --_Count, ++_Next) {
*_Next = _Ch;
}
for (_Elem* _Next = _First; _Count > 0; --_Count, ++_Next) {
*_Next = _Ch;
}

return _First;
}

static _CONSTEXPR17 void assign(_Elem& _Left, const _Elem& _Right) noexcept {
#if _HAS_CXX20
if (_STD is_constant_evaluated()) {
_STD construct_at(_STD addressof(_Left), _Right);
} else
#endif // _HAS_CXX20
{
_Left = _Right;
}
_Left = _Right;
}

_NODISCARD static constexpr bool eq(const _Elem _Left, const _Elem _Right) noexcept {
Expand Down