<xstring>
: Make char_traits::assign
not start lifetime of elements
#4613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in [char.traits.specializations],
char_traits::assign
should just perform assignments. #1502 made these functions also start lifetime of elements since C++20, but this is possibly wrong as the difference is theoretically observable due to lack of constant evaluation failure. This PR reverts changes ofchar_traits::assign
.Notes:
<xstring>
: constexpr string element lifetime #3334 (and following-up PR Lifetime cleanups forbasic_string
#4047) correctly madebasic_string
start lifetime of elements when required.Edit: