Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract build logic from components page #4153

Merged
merged 11 commits into from
Sep 24, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Sep 16, 2020

Description

Actions

  • Extract build logic from components page
  • Split build logic from luUtils

Motivations

  • Support for more recognizers and custom recognizer code framework.

Task Items

closes #4092

* main:
  fix: add more missing formatMessage calls (microsoft#4144)
  feat: electron splash screen (microsoft#4119)
  feat: Add QnA files to dispatch model in skill manifest (microsoft#3985)
  fix: check whether operation is under current project folder (microsoft#4078)
  update localization and add missing "example" string (microsoft#4138)
  fix: defense invocation of `value.match()` (microsoft#4110)
  fix: checkReturnType in ExpressionValidation throws unexpected error (microsoft#4112)
  chore(deps): Bump tree-kill from 1.2.1 to 1.2.2 in /Composer (microsoft#4035)
  build: fix docker builds in ACR (microsoft#3986)
  fix: security: downgrade node-forge to 0.9.0 (microsoft#4133)
  chore: update archiver to fix security warning (microsoft#4116)
@coveralls
Copy link

coveralls commented Sep 16, 2020

Coverage Status

Coverage increased (+0.02%) to 55.648% when pulling ae13000 on alanlong9278:julong/publish-code-clean into b8d98ef on microsoft:main.

@boydc2014
Copy link
Contributor

@lei9444 @liweitian can you help review this one?

* main:
  fix: language err for build luis in azure deploy (microsoft#4155)
  fix: Unify skill and skill setting dispatchers (microsoft#4173)
@alanlong9278 alanlong9278 merged commit 388d442 into microsoft:main Sep 24, 2020
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Sep 28, 2020
* main:
  fix: Monaco editor links opened in blank window in electron (microsoft#4269)
  feat: add notification center for composer (QnA url import) (microsoft#4080)
  fix: Object examples not properly displayed as placeholders (microsoft#4126)
  fix: allows spaces in bot project path (microsoft#4260)
  chore: extract build logic from components page (microsoft#4153)
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* main:
  fix: Monaco editor links opened in blank window in electron (microsoft#4269)
  feat: add notification center for composer (QnA url import) (microsoft#4080)
  fix: Object examples not properly displayed as placeholders (microsoft#4126)
  fix: allows spaces in bot project path (microsoft#4260)
  chore: extract build logic from components page (microsoft#4153)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* main:
  fix: Monaco editor links opened in blank window in electron (#4269)
  feat: add notification center for composer (QnA url import) (#4080)
  fix: Object examples not properly displayed as placeholders (#4126)
  fix: allows spaces in bot project path (#4260)
  chore: extract build logic from components page (#4153)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* add build util to package build logic

* refactor

* test fix

* code refactor

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

put qna / lu / publish/ build logic together
4 participants