Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unify skill and skill setting dispatchers #4173

Merged
merged 9 commits into from
Sep 18, 2020
Merged

fix: Unify skill and skill setting dispatchers #4173

merged 9 commits into from
Sep 18, 2020

Conversation

tdurnford
Copy link
Collaborator

Description

  • Added a skill indexer that recreates the skill state when the skills related settings are updated.
  • dispatchers
    • setSettings: Modified the dispatcher to update the skillsState when the settings are changed
    • addSkill, updateSkill, removeSkill: Updated the dispatchers to only set the skill's settings and not the skillState
    • updateSkillsInSettings: Removed in favor of updateSkill

Task Item

Closes #4172

@tdurnford tdurnford marked this pull request as ready for review September 17, 2020 22:30
@coveralls
Copy link

coveralls commented Sep 17, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 55.307% when pulling 9be2b48 on tdurnford:fix/skill-dispatchers into 3c60d8a on microsoft:main.

srinaath
srinaath previously approved these changes Sep 18, 2020
View reviewed changes
@srinaath srinaath self-requested a review September 18, 2020 16:46
@srinaath srinaath merged commit f4853c6 into microsoft:main Sep 18, 2020
@tdurnford tdurnford deleted the fix/skill-dispatchers branch September 18, 2020 16:51
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Sep 21, 2020
@alanlong9278
Merge branch 'main' into julong/publish-code-clean
1c38e63 
* main:
  fix: language err for build luis in azure deploy (microsoft#4155)
  fix: Unify skill and skill setting dispatchers (microsoft#4173)
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@tdurnford
fix: Unify skill and skill setting dispatchers (microsoft#4173)
b129b7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinaath srinaath srinaath approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@srinaath srinaath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The setSettings dispatcher should update the skills state
3 participants
@tdurnford @coveralls @srinaath