Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove lib folder under client extensions #4113

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Conversation

VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Sep 14, 2020

Description

This PR remove the /extensions folder in client.
because all extension under /extensions were move to /packages in #4075, but its lib folders are still in main branch.

Task Item

#minor

Screenshots

@VanyLaw
Copy link
Contributor Author

VanyLaw commented Sep 14, 2020

Hi @a-b-r-o-w-n, I saw you rename all extension in /extensions, So I think all the /extensions can be removed. What do you think?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.494% when pulling 680385c on wenyluo/polish into 8d7187c on main.

@a-b-r-o-w-n
Copy link
Contributor

It looks like the lib directories were committed in #3913. They were removed in #4075, so this looks good to me.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 03b7589 into main Sep 14, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the wenyluo/polish branch September 14, 2020 14:57
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* remove plugin-loader lib

* remove extensions folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants