feature: localization framework and pseudolocalization #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might be why the e2e step is failing; it wasn't creating the schema files that get copied over into new projects by default.
…Framework-Composer into beyackle/l10n-mock
a-b-r-o-w-n
previously requested changes
Sep 8, 2020
| @@ -264,7 +265,7 @@ export class BotProject implements IBotProject { | |||
|
|
|||
| return { | |||
| sdk: { | |||
| content: sdkSchema, | |||
| content: merge(sdkSchema, uiSchemaOverrides), | |||
There was a problem hiding this comment.
This doesn't look right. We should not merge the ui schema into the sdk schema.
| 'manifests/*.json', | ||
| 'sdk.override.uischema', | ||
| 'sdk.schema', | ||
| 'sdk.uischema', |
There was a problem hiding this comment.
That happens in the constructor though right?
beyackle
requested review from
GeoffCoxMSFT,
hatpick and
yeze322
as code owners
cwhitten
approved these changes
Sep 12, 2020
Merged
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* create l10n-extract script * Update l10n-extract.js * clean up code and move files into own directory * rename files * Update l10n-extract.js * refactor utils and fix small bug * add pseudol10n for client locales file * add pseudolocalization * Update index.tsx * Update botProject.ts * transform other files * move locales into src * unify .json files * move format-message and other fixes * merge in settings dropdown * almost-working locale serverside locale swap * Update App.tsx * fix server silliness * move locale-loading to dispatcher * Update user.ts * fix scripts * remove stray files * make serverside schemas mostly work * Update dialogUtil.ts * use override files * WIP on schema override reading * fix filename typo * Update botProject.ts * move loadLocale out and use for init * fix l10n script * fix typo * delay concept labels * Update viewUtils.ts * Update package.json * update tests (still WIP) * Update fileUtil.test.js * fix loadLocale tests * Update .gitignore * remove pseudo files * fix design of settings * Update AppSettings.tsx * Update en-US.json * fix CR issues and move schema files * add l10n to build scripts This might be why the e2e step is failing; it wasn't creating the schema files that get copied over into new projects by default. * Update botProject.ts * resolve node-forge to 0.10 for security thing * Update LuisDeploy.spec.ts * fixes from CR * Update botProject.ts * rebuild files * post-merge fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds in the ability to swap between locales in User Settings, along with a pseudo-locale to be used for testing purposes.
yarn l10nto regenerate the locale files; there's a check now to add the pseudo-locale and "does not exist" locale to the settings box in non-prod settings.-- Done, thanks to Vivek on the design team
-- Fixed (I discovered how to do this on my own)
Task Item
closes #3809
Screenshots