Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Prometheus API Collector.Type enum' value UNTYPED to UNKNOWN #2418

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Rename Prometheus API Collector.Type enum' value UNTYPED to UNKNOWN #2418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...meter-registry-prometheus/src/main/java/io/micrometer/prometheus/MicrometerCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,11 @@ public List<MetricFamilySamples> describe() {
case LONG_TASK_TIMER:
return Arrays.asList(
new MetricFamilySamples(conventionName, Type.HISTOGRAM, help, Collections.emptyList()),
new MetricFamilySamples(conventionName, Type.UNTYPED, help, Collections.emptyList()));
new MetricFamilySamples(conventionName, Type.UNKNOWN, help, Collections.emptyList()));

default:
return Collections.singletonList(
new MetricFamilySamples(conventionName, Type.UNTYPED, help, Collections.emptyList()));
new MetricFamilySamples(conventionName, Type.UNKNOWN, help, Collections.emptyList()));
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...r-registry-prometheus/src/main/java/io/micrometer/prometheus/PrometheusMeterRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ protected <T> FunctionCounter newFunctionCounter(Meter.Id id, T obj, ToDoubleFun

@Override
protected Meter newMeter(Meter.Id id, Meter.Type type, Iterable<Measurement> measurements) {
Collector.Type promType = Collector.Type.UNTYPED;
Collector.Type promType = Collector.Type.UNKNOWN;
switch (type) {
case COUNTER:
promType = Collector.Type.COUNTER;
Expand Down