Rename Prometheus API Collector.Type enum' value UNTYPED to UNKNOWN #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to UNKNOWN, since the release 0.10.0 / 2021-01-25
|
@rossisandro Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@rossisandro Thank you for signing the Contributor License Agreement! |
shakuzen
added
registry: prometheus
shakuzen
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Thanks for noticing and sending a pull request. This is a good reminder to take a look at anything else we should be doing (if anything) to support OpenMetrics, which seems to be the primary change in the 0.10 release of the Prometheus Java client. I'll open a separate issue for that.
rossisandro
deleted the
feature/prometheus-Collector-Type-enum-value-UNTYPED-renamed-to-UNKNOWN
branch
2 tasks
shakuzen
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The io.prometheus.client.Collector.Type enum' value UNTYPED was renamed to UNKNOWN, since the release 0.10.0 / 2021-01-25
The gradle settings for the versioning of the prometheus API are set to always get the latest version. Consequently, there has been a compilation error on the master branch since this change was released.