Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gimbal mode support #815

Merged
merged 23 commits into from
Jul 31, 2019
Merged

Conversation

douglaswsilva
Copy link
Collaborator

Implementation of set gimbal mode per: mavlink/MAVSDK-Proto#93

@julianoes:
"YAW_FOLLOW means that the gimbal follows the autopilot yaw, so it always looks forward (although with a little bit of damping so the picture is smoother).
YAW_LOCK means that the gimbal locks onto a specific heading no matter what direction the drone faces."

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! See inline feedback.

src/plugins/gimbal/include/plugins/gimbal/gimbal.h Outdated Show resolved Hide resolved
src/plugins/gimbal/include/plugins/gimbal/gimbal.h Outdated Show resolved Hide resolved
src/plugins/gimbal/gimbal_impl.cpp Outdated Show resolved Hide resolved
src/plugins/gimbal/gimbal_impl.cpp Outdated Show resolved Hide resolved
@JonasVautherin
Copy link
Collaborator

It should also update the proto submodule, right? Note that there may be a small typo to fix in offboard, from this PR in MAVDSK-Proto.

@JonasVautherin
Copy link
Collaborator

JonasVautherin commented Jul 27, 2019

I fixed the typo in #821, while updating the proto submodule. So you won't have to update the proto submodule here (but don't forget to update your branch) 😊.

julianoes
julianoes previously approved these changes Jul 29, 2019
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

src/plugins/gimbal/gimbal_impl.cpp Show resolved Hide resolved
@JonasVautherin JonasVautherin merged commit 159053d into mavlink:develop Jul 31, 2019
@julianoes
Copy link
Collaborator

Thanks a lot @douglaswsilva!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants