Pull updates from origin #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extracts the part where the options are parsed. This is a preparation to support range based params.
This brings initial support in the camera plugin for range based parameters. Range based parameters are paramaters without a predefined option list like an enum but rather a min, max, step size and a type.
This adds a timeout to actually set local and global position health flags to false if we lose GPS. This implementation is still clunky until we have the events interface.
camera: support for range based params
When nothing weas being received over serial the destruction of the serial connection hung waiting for a read to complete. By using a timeout every second, we can recover after one second. It's not optimal but better than stalling completely.
Because that's common for a library to implement.
We like name changes very much.
core: added getter for version
telemetry: fix position health flags on GPS loss
core: fix destruction of serial connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge remote changes.