Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assumption on sysids per udp packet #1462

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Remove assumption on sysids per udp packet #1462

merged 1 commit into from
Jun 10, 2021

Conversation

JonasVautherin
Copy link
Collaborator

Resolves #1454

julianoes
julianoes approved these changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, now I understand it. So this happens if we coalesce multiple MAVLink messages from different remotes into one UDP packet?

@JonasVautherin
Copy link
Collaborator Author

Yes! Not sure how often that happens (my opinion is that it should not), but nothing prevents it anywhere...

@julianoes julianoes merged commit ab7ef39 into main Jun 10, 2021
@julianoes julianoes deleted the do-not-assume-one-sysid-per-udp branch June 10, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we assume that a UDP packet contains messages from only one system?
2 participants
@JonasVautherin @julianoes