Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we assume that a UDP packet contains messages from only one system? #1454

Closed
JonasVautherin opened this issue Jun 3, 2021 · 1 comment · Fixed by #1462
Closed
Labels

Comments

@JonasVautherin
Copy link
Collaborator

I was just reading the code, and wondered about this:

            if (!saved_remote && sysid != 0) {
                saved_remote = true;

This is an optimization so that it does not "save" the remote for each message of the UDP packet, right?

I'm just thinking that this assumes that a UDP packet only ever contains messages from one sysid. Not sure if that's relevant or not, but I can imagine situations where this will give weird results 🤔.

@julianoes julianoes added the bug label Jun 7, 2021
@julianoes
Copy link
Collaborator

Doesn't sound like that's correct, thanks for bringing it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants