Update jsoncpp #1395
Merged
Update jsoncpp #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
update-jsoncpp
branch
3 times, most recently
from
53c999d
to
6f3e460
Compare
JonasVautherin
commented
Apr 2, 2021
|
Awesome! |
JonasVautherin
force-pushed
the
update-jsoncpp
branch
from
6f3e460
to
6c75e87
Compare
|
FYI: I just merged open-source-parsers/jsoncpp#1271 . Please let us know if that causes a problem for you. |
JonasVautherin
force-pushed
the
update-jsoncpp
branch
from
6c75e87
to
d4a487b
Compare
|
I suggest we move to jsoncpp's HEAD until they make a new release, so that we already benefit from those CMake improvements 👍 |
julianoes
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not using upstream, but a PR there (i.e. it will have to wait before being mergeable here).
Good news is that it removes the patches 👍.