-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure Cmake for Cpp package managers #1391
Comments
How did you update |
I removed lines 18-23. It is unlikely to work in other cases - that why I have not submitted a PR. |
But why doesn't We use pkgconfig as a fallback already... |
Yes you're correct. It was not working due to the aliased lib names in the provided Find cmake modules. I no longer use the provided
|
FYI, I believe it should be fixed for jsoncpp using #1395. It's not a release yet, so I don't really know how it goes with Hunter, but I think jsoncpp now has the behavior you expect. |
Aha, Good news :) I will wait for fresh Once this is all done I will update the PR #1393, it should be a relatively light-touch hunter integration at that point :) |
Progressing hunter to include MAVSDK as a lib, I have noticed the build fails due to missing submodules in I think the solution here is to put the mavlink headers into hunter, and on |
@bazfp added hunter support. |
It would be useful to be able to use MAVSDK with cpp package managers (Hunter, Conan etc) for automatic dependency resolution. Instead of depending on a
SUPERBUILD
or local dependencies.I've been implementing this library with hunter and have found success by doing the following:
SUPERBUILD=OFF
JsonCpp::jsoncpp
->jsoncpp_lib
tinyxml2::tinyxml2
->tinyxml2
This won't work for
mavsdk_server
but it is a start. There is likely to be more changes to this to get it to work (for Hunter I have included Hunter_gate but obviously this differs for each manager :) )The text was updated successfully, but these errors were encountered: