Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3192: Batch state endpoint #3192

Draft
wants to merge 6 commits into
base: old_master
Choose a base branch
from
Draft

MSC3192: Batch state endpoint #3192

wants to merge 6 commits into from
+176 −0

Conversation

clokep
Copy link
Member

@clokep clokep commented May 12, 2021

@clokep clokep added kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal labels May 12, 2021
@clokep clokep mentioned this pull request May 12, 2021
Open
@turt2live turt2live added kind:maintenance MSC which clarifies/updates existing spec client-server Client-Server API and removed kind:feature MSC for not-core and not-maintenance stuff labels May 12, 2021
kevincox
kevincox reviewed May 13, 2021
View reviewed changes
proposals/3192-batch-state.md Show resolved Hide resolved
proposals/3192-batch-state.md Outdated Show resolved Hide resolved
kevincox
kevincox reviewed May 13, 2021
View reviewed changes
proposals/3192-batch-state.md Outdated Show resolved Hide resolved
proposals/3192-batch-state.md Show resolved Hide resolved
proposals/3192-batch-state.md Outdated Show resolved Hide resolved
proposals/3192-batch-state.md Show resolved Hide resolved
proposals/3192-batch-state.md

Limiting the number of state events in a single API call to match what can be
done by an abusive sever over federation should offer a level of security as
well.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably worth adding that servers should consider rate-limiting at a per-event level rather than treating this endpoint as a single "unit" of rate-limiting consumption.

@MadLittleMods MadLittleMods mentioned this pull request May 14, 2021
Merged
9 tasks
clokep and others added 2 commits May 17, 2021 09:29
@clokep @MadLittleMods
Fix typo.
317c95c 
Co-authored-by: Eric Eastwood <erice@element.io>
@clokep
Rework to be more generic -- handle multiple event types in a single …
5addf0b 
…API call.
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
@clokep clokep mentioned this pull request Mar 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox left review comments

@MadLittleMods MadLittleMods MadLittleMods left review comments

@ara4n ara4n ara4n left review comments

@toger5 toger5 toger5 left review comments

Assignees
No one assigned
Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clokep @kevincox @MadLittleMods @ara4n @toger5 @turt2live