This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix duplicate EventListSummarys #7952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Townsend <robin@robin.town>
Signed-off-by: Robin Townsend <robin@robin.town>
github-actions
bot
added
the
T-Defect
t3chguy
reviewed
Mar 2, 2022
| }); | ||
| // Populate the weak map with the key. | ||
| // Note that we only set the key on the specific event it refers to, since this group might get | ||
| // split up in the future by other intervening events. If we were to set the key on all events |
There was a problem hiding this comment.
When would this split up happen?
There was a problem hiding this comment.
I wasn't able to find the specific cause, but I think what's happening is that when restarting Element, it pre-populates the timeline with state events that it knows about. Fetching the actual messages for the room can then split up these summaries.
t3chguy
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Looks sane, might regress element-hq/element-web#9192 if an unpagination happens but that's relatively minor in comparison
|
I don't think the previous approach fully worked for unpaginations anyways, so yeah, this is a pretty minor step backward |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: defect
element-web notes: none
Notes: none
Closes element-hq/element-web#21245.
Closes element-hq/element-web#21261.
This change has no change notes, so will not be included in the changelog.
Preview: https://pr7952--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.