Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various rooms seem to repeat chains of state events and read receipts #21245

Closed
jryans opened this issue Mar 1, 2022 · 6 comments · Fixed by matrix-org/matrix-react-sdk#7952
Closed

Various rooms seem to repeat chains of state events and read receipts #21245

jryans opened this issue Mar 1, 2022 · 6 comments · Fixed by matrix-org/matrix-react-sdk#7952
Assignees
@robintown
Labels
A-Read-Receipts A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 1, 2022

Steps to reproduce

  1. Look at some rooms, perhaps scroll up a bit (I am not quite sure what it takes)

Outcome

What did you expect?

State events and read receipts should only appear in one place in the timeline. Event level "..." menus should open when clicked.

What happened instead?

As seen below, some state events seem to repeat in a loop, as well as read receipts down the side. Also, the "..." menu on the state events does not want to open.

image

Operating system

macOS

Browser information

Firefox 99

URL for webapp

develop.element.io

Application version

Element version: de9e65d-react-36adba101caf-js-54e815085f4d, Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

Yes
@jryans jryans added T-Defect A-Timeline A-Read-Receipts O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Regression labels Mar 1, 2022
@t3chguy
Copy link
Member

t3chguy commented Mar 1, 2022

Possibly a Synapse/matrix.org issue.

@robintown
Copy link
Member

Could be related to matrix-org/matrix-react-sdk#7915 ?

@t3chguy
Copy link
Member

t3chguy commented Mar 1, 2022

Unlikely as that only governs what key to cache-bust React using, it should never be possible for that to result in multiple renders

@jryans
Copy link
Collaborator Author

jryans commented Mar 1, 2022

I haven't seen at all after this morning, so perhaps something server-side indeed.

@robintown
Copy link
Member

I can reproduce this pretty much consistently on develop, but upon reverting matrix-org/matrix-react-sdk#7915 have not been able to get it to happen once. #21261 seems to be able to explain why key changes would cause this.

@MadLittleMods MadLittleMods mentioned this issue Mar 2, 2022
Closed
@jryans
Copy link
Collaborator Author

jryans commented Mar 2, 2022

I am also seeing this again this morning, so sounds like we're back to thinking it's a client regression.

@robintown robintown self-assigned this Mar 2, 2022
@robintown robintown mentioned this issue Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robintown robintown

Labels
A-Read-Receipts A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix duplicate EventListSummarys robintown/matrix-react-sdk
4 participants
@novocaine @jryans @t3chguy @robintown