This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Edit history dialog #3144
Merged
Edit history dialog #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including: - respect 12/24 hour setting - pillify
jryans
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
Thanks for working on this! It's looking quite nice. 😁
The dialog design currently looks a bit different than the design in Zeplin, but it looks you have that down as a task still left to work on.
I have left a number of comments to address before merging, but I don't think it needs another review after you fix, so marking as approved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part for element-hq/element-web#9490
Requires matrix-org/matrix-js-sdk#967