Relations endpoint support #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
requested changes
Jun 26, 2019
| @@ -439,6 +439,27 @@ MatrixBaseApis.prototype.createRoom = function(options, callback) { | |||
| ); | |||
| }; | |||
|
|
|||
| MatrixBaseApis.prototype.fetchRelations = | |||
There was a problem hiding this comment.
Please add function docs like other functions here.
src/base-apis.js
Outdated
| async function(roomId, eventId, relationType, eventType, opts) { | ||
| const queryParams = {}; | ||
| if (opts.token) { | ||
| queryParams.from = opts.token; |
There was a problem hiding this comment.
I assume the name token matches other APIs?
src/base-apis.js
Outdated
| $relationType: relationType, | ||
| $eventType: eventType, | ||
| }); | ||
| // valid options include: room_alias_name, visibility, invite |
There was a problem hiding this comment.
What does this means? Options for what...?
| @@ -3965,6 +3965,20 @@ MatrixClient.prototype.getCanResetTimelineCallback = function() { | |||
| return this._canResetTimelineCallback; | |||
| }; | |||
|
|
|||
| MatrixClient.prototype.relations = | |||
There was a problem hiding this comment.
This should also have function docs like others here.
|
Sorry for the messy initial state, should be better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for element-hq/element-web#9490
React-sdk PR: matrix-org/matrix-react-sdk#3144