Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live location sharing: handle encrypted messages in processBeaconEvents #2327

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 28, 2022


Here's what your changelog entry will look like:

✨ Features

  • Live location sharing: handle encrypted messages in processBeaconEvents (#2327). Contributed by @kerryarchibald.

Kerry Archibald added 2 commits April 28, 2022 14:08
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@codecov-commenter
Copy link

Codecov Report

Merging #2327 (2977e64) into develop (3649cf4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2327      +/-   ##
===========================================
+ Coverage    59.75%   59.76%   +0.01%     
===========================================
  Files           91       91              
  Lines        16450    16456       +6     
  Branches      3798     3801       +3     
===========================================
+ Hits          9829     9835       +6     
  Misses        6621     6621              
Impacted Files Coverage Δ
src/client.ts 38.11% <100.00%> (-0.03%) ⬇️
src/models/room-state.ts 77.87% <100.00%> (+0.45%) ⬆️

@kerryarchibald kerryarchibald changed the title Psf 951/beacons encrypted Live location sharing: handle encrypted messages in processBeaconEvents Apr 28, 2022
@kerryarchibald kerryarchibald marked this pull request as ready for review April 28, 2022 13:29
@kerryarchibald kerryarchibald requested a review from a team as a code owner April 28, 2022 13:29
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane!

@kerryarchibald kerryarchibald merged commit 34ee566 into develop Apr 28, 2022
@kerryarchibald kerryarchibald deleted the psf-951/beacons-encrypted branch April 28, 2022 14:42
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request May 10, 2022
* Live location sharing: handle encrypted messages in processBeaconEvents ([\matrix-org#2327](matrix-org#2327)).
* Fix race conditions around threads ([\matrix-org#2331](matrix-org#2331)). Fixes element-hq/element-web#21627.
* Ignore m.replace relations on state events, they're invalid ([\matrix-org#2306](matrix-org#2306)). Fixes element-hq/element-web#21851.
* fix example in readme ([\matrix-org#2315](matrix-org#2315)).
* Don't decrement the length count of a thread when root redacted ([\matrix-org#2314](matrix-org#2314)).
* Prevent attempt to create thread with id "undefined" ([\matrix-org#2308](matrix-org#2308)).
* Update threads handling for replies-to-thread-responses as per MSC update ([\matrix-org#2305](matrix-org#2305)). Fixes element-hq/element-web#19678.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants