Prevent attempt to create thread with id "undefined" #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2308 +/- ##
===========================================
- Coverage 59.74% 59.74% -0.01%
===========================================
Files 91 91
Lines 16448 16449 +1
Branches 3795 3796 +1
===========================================
Hits 9827 9827
- Misses 6621 6622 +1
|
germain-gg
approved these changes
Apr 21, 2022
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
May 10, 2022
* Live location sharing: handle encrypted messages in processBeaconEvents ([\matrix-org#2327](matrix-org#2327)). * Fix race conditions around threads ([\matrix-org#2331](matrix-org#2331)). Fixes element-hq/element-web#21627. * Ignore m.replace relations on state events, they're invalid ([\matrix-org#2306](matrix-org#2306)). Fixes element-hq/element-web#21851. * fix example in readme ([\matrix-org#2315](matrix-org#2315)). * Don't decrement the length count of a thread when root redacted ([\matrix-org#2314](matrix-org#2314)). * Prevent attempt to create thread with id "undefined" ([\matrix-org#2308](matrix-org#2308)). * Update threads handling for replies-to-thread-responses as per MSC update ([\matrix-org#2305](matrix-org#2305)). Fixes element-hq/element-web#19678.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what your changelog entry will look like:
🐛 Bug Fixes