This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Update tests, port fix to gl-js #5544. #10398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an ignore for the "mixed-zoom" test (#10397), although it might be a good idea to implement soon/as part of the
start-collisionPR.On my machine there's now one failing render test (minor difference in symbol-visibility/visible) and two failing query tests. The query tests are failing because they're returning results in a different order from JS.
Ports fix to mapbox/mapbox-gl-js#5544.
/cc @ansis @jfirebaugh