keep-upright for single-glyph vertical text may be broken

[ChrisLoer]

I haven't tested this yet, but while porting #5150 to native, I noticed what looks like a vestigial use of symbol.vertical at

mapbox-gl-js/src/symbol/projection.js

Line 302 in 5740526

if (symbol.vertical ? b.y > a.y : b.x < a.x) {

.

I'm pretty sure vertical isn't a member of the placedSymbols anymore. We should be using symbol.writingMode == WritingMode.vertical. I believe what will happen is that single-glyph CJK labels will be upside down over a 90 degree range.

Needs a regression test.

/cc @ansis @1ec5

[1ec5]

I believe what will happen is that single-glyph CJK labels will be upside down over a 90 degree range.

I’m not seeing any issues with this way tagged name=桥 when rendered in the Mapbox Streets style.

[ChrisLoer]

Thanks for that example, @1ec5. It looks like the keepUpright problem is being hidden by vertical text just being disabled entirely for single glyph labels.