Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[build] Shuffle render tests in 'test-node-recycle-map' target #10032

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

brunoabinader
Copy link
Member

Enables shuffling render tests when recycling the map object.

I've let it running continuously throughout the last weekend using the following command without any additional issues found:

$ true; while [ $? -eq 0 ]; do node platform/node/test/render.test.js --recycle-map --shuffle; done

So far we've solved all of the bugs (and bugfixes) found while running this technique. #9978 is the last one open, which is fixed in #9931.

Depends on: #9931.

@brunoabinader
Copy link
Member Author

Additional note: In Node render tests, when --shuffle option is passed without --seed, a random-generated seed is designated. This seed is shown on the command line in runtime prior to start running the tests.

Render tests in node6-clang39-debug have the shuffling+recycled map option enabled in its render tests, thus if a failure is catch, we can reproduce it by re-running the tests using the given seed mentioned above.

@brunoabinader
Copy link
Member Author

This is how you obtain the random seed generated:

screenshot from 2017-09-20 11-22-13

(This particular test run succeeded because the shuffled test sequence did not triggered the flow described in #9978).

Copy link
Contributor

@lbud lbud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍝

@brunoabinader brunoabinader merged commit fc2ca19 into master Sep 21, 2017
@brunoabinader brunoabinader deleted the test-node-recycle-map-shuffle-render-tests branch September 21, 2017 21:31
@kkaefer kkaefer added Core The cross-platform C++ core, aka mbgl and removed tests labels Oct 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants