Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Shuffling causes fill-extrusion-color/property-function to fail #9978

Closed
brunoabinader opened this issue Sep 12, 2017 · 2 comments · Fixed by #9931
Closed

Shuffling causes fill-extrusion-color/property-function to fail #9978

brunoabinader opened this issue Sep 12, 2017 · 2 comments · Fixed by #9931
Assignees
Labels
bug Core The cross-platform C++ core, aka mbgl

Comments

@brunoabinader
Copy link
Member

Reproduced via:

$ node platform/node/test/render.test.js \
    --recycle-map "fill-extrusion-pattern/missing" "fill-extrusion-color/property-function"
* ignore fill-extrusion-pattern missing (https://github.com/mapbox/mapbox-gl-js/issues/3327)
* failed fill-extrusion-color property-function
1 passed but were ignored (50.0%)
1 failed (50.0%)
expected actual diff
expected actual diff

It seems the previous faulty fill-extrusion-pattern/missing run is messing with the layer z-ordering in fill-extrusion-color/property-function.

/cc @lbud

@brunoabinader brunoabinader added bug Core The cross-platform C++ core, aka mbgl labels Sep 12, 2017
@lbud lbud self-assigned this Sep 12, 2017
@lbud
Copy link
Contributor

lbud commented Sep 19, 2017

I started digging into this and realized something extra weird was going on where only sometimes, and only (afaict) when using fill-extrusion-pattern layers, the extrusion texture was being bound without a depth buffer. This can happen with missing patterns (like in this case) or with valid patterns, with other layers or without — my best guess is that something in the ImageManager binding is interfering with the state. I haven't figured out exactly what it is yet, BUT since #9931 majorly overhauls the way create/use offscreen textures for extrusions, I tested several cases/platforms where I was reproducing this bug on that branch and it seems to fix them. 🤷‍♀️

@brunoabinader
Copy link
Member Author

That's great news @lbud!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants