Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when trying to use SVG in image source #7313

Merged
merged 4 commits into from
Sep 24, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/util/ajax.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export const getImage = function(requestParameters: RequestParameters, callback:
callback(null, img);
URL.revokeObjectURL(img.src);
};
img.onerror = () => callback(new Error('Could not load image. Please make sure to use a supported image type such as PNG or JPEG. Note that SVGs are not supported.'));
const blob: Blob = new window.Blob([new Uint8Array(imgData.data)], { type: 'image/png' });
(img: any).cacheControl = imgData.cacheControl;
(img: any).expires = imgData.expires;
Expand Down