Add error message when trying to use SVG in image source #7313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
previously requested changes
Sep 24, 2018
src/util/ajax.js
Outdated
| @@ -158,10 +158,15 @@ export const getImage = function(requestParameters: RequestParameters, callback: | |||
| } else if (imgData) { | |||
| const img: HTMLImageElement = new window.Image(); | |||
| const URL = window.URL || window.webkitURL; | |||
| console.log('get image', imgData); | |||
src/util/ajax.js
Outdated
| img.onerror = () => { | ||
| const err = new Error('Image sources cannot use SVG files'); | ||
| callback(err); | ||
| }; |
There was a problem hiding this comment.
Maybe let's do a shorter version?
img.onerror = () => callback(new Error('Image sources cannot use SVG files'));
mollymerp
reviewed
Sep 24, 2018
src/util/ajax.js
Outdated
| @@ -162,6 +162,7 @@ export const getImage = function(requestParameters: RequestParameters, callback: | |||
| callback(null, img); | |||
| URL.revokeObjectURL(img.src); | |||
| }; | |||
| img.onerror = () => callback(new Error('Image sources cannot use SVG files')); | |||
There was a problem hiding this comment.
Aren't there other possible reasons for an error here? There's no check that it was actually passed an SVG to begin with. Maybe something more general like 'Unable to load image. Please make sure you're using a supported image type like PNG or JPEG. SVGs are not supported' ?
There was a problem hiding this comment.
Yeah that's a good point. I'll update the error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Fixes #7312
Superseding #5240
#5240 is out of date and it's easier just to open a new one and close that. JSDom still does not implement
URL.createObjectURLorURL.revokeObjectURLso there's not a good way to add a test for this. It's pretty simple though and worked as expected in manual debugging so I think no test is fine.