Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow interpolation for variable-length numeric arrays #5519

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Disallow interpolation for variable-length numeric arrays #5519

merged 2 commits into from
Oct 25, 2017

Commits on Oct 25, 2017

  1. Disallow interpolation for variable-length numeric arrays

    Anand Thakker committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    353c5dd View commit details
    Browse the repository at this point in the history

  2. Add separate unit test for piecewise-constant check 

    The previous commit causes the 'curve' parsing validation to preempt
createExpression()'s check for piecewise-constant zoom function using
'step' interpolation, because `line-dasharray`'s style spec type,
`array<number>`, already isn't interpolatable.

Adding this unit test to make sure we always enforce step curves, even
for a theoretical style property whose base type is interpolatable.
    Anand Thakker committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    b692586 View commit details
    Browse the repository at this point in the history