Disallow interpolation for variable-length numeric arrays #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
force-pushed
the
uninterpolatable-number-array
branch
from
04943b7
to
353c5dd
Compare
The previous commit causes the 'curve' parsing validation to preempt createExpression()'s check for piecewise-constant zoom function using 'step' interpolation, because `line-dasharray`'s style spec type, `array<number>`, already isn't interpolatable. Adding this unit test to make sure we always enforce step curves, even for a theoretical style property whose base type is interpolatable.
anandthakker
force-pushed
the
uninterpolatable-number-array
branch
from
37de50c
to
b692586
Compare
jfirebaugh
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.