Fix: #11516, #11041. Terrain: buildings on tile borders. #11530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion calculation for complex polygons: when enumerating polygon rings, if previous rings were outside bookkeeped aabb would prevent checking if edge crosses tile border and disable joining and displaying features split and asserting on check (in dev build). Backporting fill extrusions on terrain #11041 fix from gl-native is related: when adjacent tiles are of different zooms, breaks or no building parts were visible. Fixes: #11516, #11041
astojilj
added
bug 🐞
skip changelog
There is occasional flakiness on rendering fill color (zoom 16 evaluation is not seen on drape but zoom 15) and fill color is made constant to prevent it.
karimnaaji
reviewed
Feb 22, 2022
There was a problem hiding this comment.
Thanks for the port @astojilj, I compared both js and native and the fix looks good compared to the state of gl-native and good to merge to be on-par.
A separate issue should be captured for cases that aren't tied to low building footprints. I noticed some issues present in both js/native with regards to sometimes missing polygon at the edges of the viewport and polygons cutting through for large polygon spans:
gl-native
native.mp4
gl-js
Screen.Recording.2022-02-22.at.3.16.04.PM.mov
It's reproducible at location http://localhost:9966/debug/globe-fill-extrusion.html#2.17/36.04/-65.84 at a resolution of about w: 1440 by h: 740 by toggling terrain on/off.
karimnaaji
approved these changes
Mar 8, 2022
|
Going ahead with merging as the main issues reported in #11516 are fixed with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11516: unecessary optimization approach disabled border intersection calculation for complex polygons: when enumerating polygon rings, if previous rings were outside aabb calculated so far would prevent check if edge crosses tile border and would, as a consequence, disable joining and displaying features split and asserting on check (in dev build).
Backporting fill extrusions on terrain #11041 fix from gl-native is related: when adjacent tiles are of different zooms, breaks or no building parts were visible.
Situation before this PR:
before.mov
After:
after.mov
Render tests:
render-tests/fill-extrusion-terrain/flat-roof-over-border-of-different-zoom && zoomin removed from ignore list
Skipped changelog - cosmetic issue (missing building parts) that doesn't assert in production code.
Fixes: #11516, #11041
Launch Checklist
- [ ] document any changes to public APIs- [ ] post benchmark scores- [ ] tagged@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes- [ ] tagged@mapbox/gl-nativeif this PR includes shader changes or needs a native port- [ ] add an entry inside this element for inclusion in themapbox-gl-jschangelog:<changelog></changelog>