Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

new theme for search button #189

Merged
merged 4 commits into from
Nov 6, 2019
Merged

new theme for search button #189

merged 4 commits into from
Nov 6, 2019

Conversation

katydecorah
Copy link
Contributor

This PR can be reviewed when we're ready to make the next release.

This PR updates the theme for the Search button:

  • Uses Assembly btn classes for consistency
  • Makes button a little more prominent, without drawing too much attention
  • Uses accessible colors (current contrast ratio is too low)

Default

Status Image
Before image
After image

Dark

Status Image
Before image
After image

@katydecorah
Copy link
Contributor Author

@colleenmcginnis if we have time to review, this would be good to add in the next release!

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this new style @katydecorah! I'm noticing the formatting gets a little messy in your example right before the break when the search bar jumps onto its own line:

image

Do you think that's something we can/should address?

@katydecorah
Copy link
Contributor Author

katydecorah commented Oct 31, 2019

I'm noticing the formatting gets a little messy in your example right before the break when the search bar jumps onto its own line:

@colleenmcginnis The test case was using code that we normally don't use in the topbarsticker, I updated it and it scales much cleaner!

Do you think that's something we can/should address?

This was related to code holding the search button and not specific to the search button itself.

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Katy DeCorah added 2 commits November 5, 2019 19:29
* master:
  Add glossary components (#192)
  prepare 0.21.3
  Adds a CSS highlighter option to highlight component (#191)
@katydecorah katydecorah merged commit 3a8f0e2 into master Nov 6, 2019
@katydecorah katydecorah deleted the search-button branch November 6, 2019 00:33
katydecorah pushed a commit that referenced this pull request Nov 6, 2019
* master:
  create new theme for search button (#189)
  Add glossary components (#192)
  prepare 0.21.3
  Adds a CSS highlighter option to highlight component (#191)
  prepare 0.21.2
  rename tests directory (#185)
  [Feedback] remove get-window (#187)
  Fix Video build (#186)
  Prepare 0.21.1
  [Feedback] send `environment` and `location` with feedback (#184)
  prepare 0.21.0
  Bump eslint-utils from 1.4.0 to 1.4.2 (#174)
  [Feedback] collect browser, operating system, preferredLanguage (#183)
  iOS and Android toggleable code snippets (#179)
  move highlight helper function to highlight component (#180)
  add missing video/index.js file (#181)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants