-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
@colleenmcginnis if we have time to review, this would be good to add in the next release! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this new style @katydecorah! I'm noticing the formatting gets a little messy in your example right before the break when the search bar jumps onto its own line:
Do you think that's something we can/should address?
@colleenmcginnis The test case was using code that we normally don't use in the topbarsticker, I updated it and it scales much cleaner!
This was related to code holding the search button and not specific to the search button itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
* master: create new theme for search button (#189) Add glossary components (#192) prepare 0.21.3 Adds a CSS highlighter option to highlight component (#191) prepare 0.21.2 rename tests directory (#185) [Feedback] remove get-window (#187) Fix Video build (#186) Prepare 0.21.1 [Feedback] send `environment` and `location` with feedback (#184) prepare 0.21.0 Bump eslint-utils from 1.4.0 to 1.4.2 (#174) [Feedback] collect browser, operating system, preferredLanguage (#183) iOS and Android toggleable code snippets (#179) move highlight helper function to highlight component (#180) add missing video/index.js file (#181)
This PR can be reviewed when we're ready to make the next release.
This PR updates the theme for the Search button:
btn
classes for consistencyDefault
Dark