This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤦♂ I didn't double check my work in the last PR and the code to evaluate the window is wrong. We can keep the original code, but use: const reducedMotion =
typeof window !== 'undefined'
? window.matchMedia('(prefers-reduced-motion: reduce)').matches
: false; I know I had implemented the use of |
This was referenced Sep 16, 2019
katydecorah
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌹 thanks colleen! sorry for the confusion 🙇♀
katydecorah
pushed a commit
that referenced
this pull request
Sep 16, 2019
* master: Fix Video build (#186)
katydecorah
pushed a commit
that referenced
this pull request
Sep 16, 2019
* master: Fix Video build (#186)
katydecorah
pushed a commit
that referenced
this pull request
Nov 6, 2019
* master: create new theme for search button (#189) Add glossary components (#192) prepare 0.21.3 Adds a CSS highlighter option to highlight component (#191) prepare 0.21.2 rename tests directory (#185) [Feedback] remove get-window (#187) Fix Video build (#186) Prepare 0.21.1 [Feedback] send `environment` and `location` with feedback (#184) prepare 0.21.0 Bump eslint-utils from 1.4.0 to 1.4.2 (#174) [Feedback] collect browser, operating system, preferredLanguage (#183) iOS and Android toggleable code snippets (#179) move highlight helper function to highlight component (#180) add missing video/index.js file (#181)
katydecorah
pushed a commit
that referenced
this pull request
Jan 7, 2020
* master: prepare 0.21.2 rename tests directory (#185) [Feedback] remove get-window (#187) Fix Video build (#186) Prepare 0.21.1 [Feedback] send `environment` and `location` with feedback (#184) prepare 0.21.0 Bump eslint-utils from 1.4.0 to 1.4.2 (#174) [Feedback] collect browser, operating system, preferredLanguage (#183) iOS and Android toggleable code snippets (#179) move highlight helper function to highlight component (#180) add missing video/index.js file (#181)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rolling out v0.21.1 to all repos, I came across a build error related to the Video component (catching on this use of
window
). I did two things in this PR to address it:getWindow
(for consistency).window
withincomponentDidMount
(this seems to be the important part).getWindow
) instate
because that seemed to be a pattern used in mr-ui components that usegetWindow
. Up for other suggestions, though!I tested this by building and installing this locally in /ios-sdk and /android-docs. I was able to build both sites successfully and the resulting static site worked as expected.