This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Adjust version-sort for XX.XX.XX format #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2019 18:17
|
@colleenmcginnis I ended up swapping out our sorting function for an npm module that will do that logic for us. I think we got it 😅 |
|
Works beautifully 💅 |
katydecorah
pushed a commit
that referenced
this pull request
May 30, 2019
* master: prepare 0.13.0 adjust version-sort for XX.XX.XX format (#132)
katydecorah
pushed a commit
that referenced
this pull request
Jun 5, 2019
* master: add snapshot tests (#136) 0.15.1 Prepare 0.15.1 0.15.0 Prepare 0.15.0 [search] adds segment tracking for queries and clicks (#140) [search] add ability to filter results (#138) increase modal zindex to prevent collision with topbar sticker (#139) 0.14.0 Prepare 0.14.0 [PageLayout/TopbarSticker] increase zIndex (#134) [search] Introduce search modal (#133) prepare 0.13.0 adjust version-sort for XX.XX.XX format (#132)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version-sort.jsis not working with numbers that have two digits in the middle number in theXX.XX.XXformat:This change should set us up for success if any of the three numbers are 1 or 2 digits by prepending single-digit numbers with
0before building thenumvalue.@katydecorah I can't get one test to pass. I would also love your thoughts on this approach!
cc @friedbunny @captainbarbosa @riastrad