Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI - make sure options are not "camelCased" but "have-dashes" instead #904

Merged
merged 5 commits into from
Mar 12, 2021
Merged

CLI - make sure options are not "camelCased" but "have-dashes" instead #904

merged 5 commits into from
Mar 12, 2021

Conversation

macbre
Copy link
Owner

@macbre macbre commented Mar 12, 2021 •
edited
Loading

Resolves #863

  • normalise options (camel-cased by commander) to dashed-notation using de-camelify
  • add CLI test cases to CI pipeline

@macbre macbre added the bug label Mar 12, 2021
@macbre macbre added this to the v2.2 milestone Mar 12, 2021
@macbre macbre marked this pull request as ready for review March 12, 2021 15:51
@macbre macbre enabled auto-merge March 12, 2021 15:52
@macbre macbre mentioned this pull request Mar 12, 2021
Closed
@macbre macbre merged commit 5fb3f06 into devel Mar 12, 2021
@macbre macbre deleted the decamelize-options branch March 12, 2021 15:53
@macbre macbre mentioned this pull request Mar 12, 2021
Merged
@gmetais
Copy link
Contributor

gmetais commented Mar 12, 2021

👍👍👍

Just wondering if this line should be camel cased:

phantomas/lib/browser.js

Line 34 in 5fb3f06

if (phantomasOptions["ignoreSslErrors"]) {

@macbre
Copy link
Owner Author

macbre commented Mar 12, 2021 •
edited
Loading

Will fix that in #906 . Thanks for spotting this one 👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

CLI options are camel cased, then do not work
2 participants
@macbre @gmetais