Merge pull request #904 from macbre/decamelize-options

CLI - make sure options are not "camelCased" but "have-dashes" instead

bin/phantomas.js

@@ -10,6 +10,7 @@
 "use strict";
 
 const { program } = require("commander"),
+  { decamelizeOptions } = require("./utils"),
   phantomas = require(".."),
   debug = require("debug")("phantomas:cli");
 
@@ -157,7 +158,9 @@ program
 
 // parse it
 program.parse(process.argv);
-var options = program.opts();
+
+// make sure options are not "camelCased" but "have-dashes" instead (issue #863)
+var options = decamelizeOptions(program.opts());
 
 debug("argv: %j", process.argv);
 debug("opts: %j", options);

bin/utils.js

@@ -0,0 +1,16 @@
+const decamelize = require("decamelize");
+
+function decamelizeOptions(options) {
+  // decamelize option names as returned by commander (see issue #863)
+  let decamelized = {};
+
+  for (const [key, value] of Object.entries(options)) {
+    decamelized[decamelize(key, { separator: "-" })] = value;
+  }
+
+  return decamelized;
+}
+
+module.exports = {
+  decamelizeOptions,
+};

package.json

@@ -35,6 +35,7 @@
     "commander": "^7.0.0",
     "csv-string": "^4.0.1",
     "debug": "^4.1.1",
+    "decamelize": "^5.0.0",
     "js-yaml": "^4.0.0",
     "node-statsd": "0.1.1",
     "puppeteer": "^8.0.0"

test/bin-utils-test.js

@@ -0,0 +1,26 @@
+/**
+ * Integration tests using server-start.sh script
+ */
+const vows = require("vows"),
+  assert = require("assert"),
+  { decamelizeOptions } = require("../bin/utils");
+
+vows
+  .describe("bin utils")
+  .addBatch({
+    decamelizeOptions: {
+      topic: function () {
+        return decamelizeOptions({
+          url: "http://foo.com",
+          userAgent: "foo/bar",
+        });
+      },
+      "should decamelize options": function (opts) {
+        assert.deepStrictEqual(opts, {
+          url: "http://foo.com",
+          "user-agent": "foo/bar",
+        });
+      },
+    },
+  })
+  .export(module);