Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39325: Move cachemachine configuration into business options #263

Merged
merged 5 commits into from
May 22, 2023
Merged

DM-39325: Move cachemachine configuration into business options #263

merged 5 commits into from
May 22, 2023

Commits on May 22, 2023

  1. Change how image is passed into JupyterClient 

    As part of the preparation for moving this into Safir, remove the
image definition from the constructor and instead make it an
argument to spawn_lab, which is the only method that requires it.
    @rra
    rra committed May 22, 2023
    Configuration menu
    Copy the full SHA
    732d2d6 View commit details
    Browse the repository at this point in the history

  2. Fix passing max WebSocket size into session 

    The previous change to add a maximum WebSocket size to the business
configuration didn't pass the setting into the client. Do so.
    @rra
    rra committed May 22, 2023
    Configuration menu
    Copy the full SHA
    7db53ce View commit details
    Browse the repository at this point in the history

  3. Pass the full base URL into JupyterClient 

    In further preparation for moving this class into Safir, pass in the
full base URL for JupyterHub instead of relying on the mobu
configuration and passing in only the URL prefix.
    @rra
    rra committed May 22, 2023
    Configuration menu
    Copy the full SHA
    4a7f68c View commit details
    Browse the repository at this point in the history

  4. Move cachemachine config to business options 

    Allow use of cachemachine and the cachemachine image policy are
now configurable in the business options rather than globally.

Move the creation of the cachemachine client into the business
layer to make it easier to move JupyterClient into Safir and
simplify its constructor. Move annotation of cachemachine exceptions
with username information into JupyterClient to simplify the
cachemachine client.
    @rra
    rra committed May 22, 2023
    Configuration menu
    Copy the full SHA
    8994dc8 View commit details
    Browse the repository at this point in the history

  5. Ignore WebSocket messages of type display_data 

    These are produced by Jupyter lab but aren't of interest to us.
    @rra
    rra committed May 22, 2023
    Configuration menu
    Copy the full SHA
    a808713 View commit details
    Browse the repository at this point in the history