DM-39325: Move cachemachine configuration into business options #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the preparation for moving this into Safir, remove the image definition from the constructor and instead make it an argument to spawn_lab, which is the only method that requires it.
The previous change to add a maximum WebSocket size to the business configuration didn't pass the setting into the client. Do so.
In further preparation for moving this class into Safir, pass in the full base URL for JupyterHub instead of relying on the mobu configuration and passing in only the URL prefix.
Allow use of cachemachine and the cachemachine image policy are now configurable in the business options rather than globally. Move the creation of the cachemachine client into the business layer to make it easier to move JupyterClient into Safir and simplify its constructor. Move annotation of cachemachine exceptions with username information into JupyterClient to simplify the cachemachine client.
These are produced by Jupyter lab but aren't of interest to us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow use of cachemachine and the cachemachine image policy are now configurable in the business options rather than globally.
Restructure code and options to move more things out of the JupyterClient class into the business logic to allow JupyterClient to more easily be moved into Safir, including managing the cachemachine client construction.
Fix passing the maximum WebSocket size into JupyterClient, missed in the previous PR.
Ignore WebSocket messages of type
display_data, since those are not interesting to us.