Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unexpected console error from pendo messsages in demo #167

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: unexpected console error from pendo messsages in demo #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/message_utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ class EmbedFrameImpl implements EmbedFrame {
if (data) {
let parsedData: any
try {
parsedData = JSON.parse(data)
parsedData = typeof data === 'object' ? data : JSON.parse(data)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oldie but goodie

} catch (error) {
console.error('data is not json', { data })
}
Expand Down
Loading