fix: unexpected console error from pendo messsages in demo #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The embed javascript demo was rendering an unexpected error message in the javascript console. The type of message data is now checked prior to parsing it.
jkaster
approved these changes
Aug 25, 2023
| @@ -406,7 +406,7 @@ class EmbedFrameImpl implements EmbedFrame { | |||
| if (data) { | |||
| let parsedData: any | |||
| try { | |||
| parsedData = JSON.parse(data) | |||
| parsedData = typeof data === 'object' ? data : JSON.parse(data) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embed javascript demo was rendering an unexpected error message in the javascript console. The type of message data is now checked prior to parsing it.