Ensure that the json written to localstorage is in the format expected by ember-data.

[mattburns]

Entities with a hasMany relationship should contain an array of IDs, not an array of embedded objects.

Without this fix, embedded objects get written to localstorage which will cannot be restored upon page refresh.

I couldn't figure out why the member "this._data" contains embedded objects. Perhaps it's supposed to as a performance enhancement and the real bug is simply that you shouldn't use JSON.stringify. Perhaps you should be using some other serializer (I had a brief search but couldn't find out how).

I struggled to get any help on this but if someone with more ember experience than me (aka some) can chip in and explain what was going on I'd love to hear it.

[mattburns]

This is all wrong! Don't pull it in!

I've realised the serialization problem is because the hasMany relationship does not have the corresponding belongsTo relationship on the other model. This wasn't enabled because of a separate bug. To solve it I simply override the implementation of "serializeHasMany" in JSONSerializer instead:

/**
 * Have to do this to enable arrays of ids to be written in parent models
 * with 'hasMany" relationships
 */
DS.JSONSerializer.reopen({
    serializeHasMany : function(record, json, relationship) {
        var key = relationship.key;

        var relationshipType = DS.RelationshipChange.determineRelationshipType(
                record.constructor, relationship);

        if (relationshipType === 'manyToNone'
                || relationshipType === 'manyToMany'
                || relationshipType === 'manyToOne') {
            json[key] = Ember.get(record, key).mapBy('id');
        }
    }
});

[soundasleep]

This is now recognised as a bug, see: emberjs/data#1678

[kurko]

I believe we can close it. Please reopen if it's still an issue.

[kurko]

Nevermind, thought it was opened.