fixes serializeHasMany relationshipType

[fsmanuel]

there is a typo in the JSONSerializer serializeHasMany that prevents hasMany relations from getting serialized.

[abuiles]

@fsmanuel this is failing in travis, also could you please add tests for this?

[rwjblue]

I agree that it seems like a typo, but apparently ManyToNone is definitely a thing. A few references:

https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/changes/relationship_change.js#L89
https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/changes/relationship_change.js#L115

[abuiles]

@rjackson wonder though about the TODO in the code.

[fsmanuel]

@abuiles @rjackson sorry for that. ok i'll add it back and add the ManyToOne.

[fsmanuel]

it seems to be intentional that there is no manyToOne. i added a test for my concern but serializeIntoHash and serializeIntoHash with decamelized typeKey of the integration/serializer/rest - RESTSerializer suite are now failing.

[fsmanuel]

@abuiles added a test and fixed the failing

[pixelhandler]

All three are needed, how about:

    var relationshipTypes = ['manyToNone', 'manyToMany', 'manyToOne'];

    if (relationshipTypes.indexOf(relationshipType) > -1) {

[fsmanuel]

i don't know which one is faster. but yours seems cleaner.

[pixelhandler]

@fsmanuel I rebased PR #1751 which also addresses this issue, I asked @igorT to take a look at that one, (said please) so hoping for some feedback soon.

[quaertym]

👍

[GetContented]

👍

[pixelhandler]

@fsmanuel PR #1751 was merged, can you confirm that fixes the same issue on this PR?

[igorT]

OneToMany are not serialized by default, because the JSON serializer assumes by default that you would save your id's as foreign keys on the child. If you need to serialize them, you can now instead of editing the serializeHasMany code, apply the EmbeddedRecordsMixin and say

attrs: { children: {serialize: 'ids'}}

I do think this is a bit non obvious, would be nice to document it better.

[fsmanuel]

@igorT thanks for the clarification and your work on ember-data. will try the attrs approach tomorrow. wasn't aware of the possibility.
my problem with the serializers was that the JSON serializer seemed to wrong in some areas and all the other serializers (REST, ActiveModel) fixed the mistakes but the JSON serializer stayed the same.