Adding support for Nodebalancer Firewall #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding missing events (#365) * implementation * fixing merge conflict * Update account_events.go Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com> --------- Co-authored-by: Jacob Riddle <87780794+jriddle-linode@users.noreply.github.com> Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
* firewall id * adding tests * fixing tests * fixing tests again * tests again * test changes * removing firewall_id * fixing test * tests again
## 📝 Description **What does this PR do and why is this change necessary?** Updating from 1.18 to 1.20 because k8s dependencies now require 1.19 or better.
lgarber-akamai
approved these changes
Sep 13, 2023
amisiorek-akamai
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
Adds
firewall_idfield toPOST /nodebalancersAlso adds missing event types
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
make ARGS="-run TestNodeBalancer_Create_create" fixtures