Add firewall_id field for NodeBalancers
#364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing verification and merging all commits (linode#347)
|
I think this field belongs to |
|
Ah you're right, not sure if it should be in the returning object too though? I see your comment on the google doc. |
zliang-akamai
requested changes
Aug 24, 2023
jriddle-linode
approved these changes
Aug 28, 2023
amisiorek-akamai
merged commit 22eb395
into
linode:feature/nodebalancer-firewall
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds firewall_id to NodeBalancer struct
✔️ How to Test
Uncomment changes related to firewall ids in setupNodeBalancer. Currently cannot have test with firewall as there is no availability in the region with api.dev and a null point error when we use api.linode.
make ARGS="-run TestNodeBalancer_Create_create" fixtures