Implement EIP-2718 & EIP-2930 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
force-pushed
the
impl-eip-2718
branch
from
aaea762
to
3651b77
Compare
holiman
added a commit
that referenced
this pull request
Oct 19, 2020
core/types: use stacktrie for derivesha trie: add stacktrie file trie: fix linter core/types: use stacktrie for derivesha rebased: adapt stacktrie to the newer version of DeriveSha Co-authored-by: Martin Holst Swende <martin@swende.se> More linter fixes review feedback: no key offset for nodes converted to hashes trie: use EncodeRLP for full nodes core/types: insert txs in order in derivesha trie: tests for derivesha with stacktrie trie: make stacktrie use pooled hashers trie: make stacktrie reuse tmp slice space trie: minor polishes on stacktrie trie/stacktrie: less rlp dancing core/types: explain the contorsions in DeriveSha ci: fix goimport errors trie: clear mem on subtrie hashing squashme: linter fix stracktrie: use pooling, less allocs (#3) trie: in-place hex prefix, reduce allocs and add rawNode.EncodeRLP Reintroduce the `[]node` method, add the missing `EncodeRLP` implementation for `rawNode` and calculate the hex prefix in place. Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Martin Holst Swende <martin@swende.se>
holiman
force-pushed
the
impl-eip-2718
branch
from
3651b77
to
2884fd4
Compare
lightclient
force-pushed
the
impl-eip-2718
branch
5 times, most recently
from
15819f1
to
142d206
Compare
lightclient
force-pushed
the
impl-eip-2718
branch
5 times, most recently
from
adde425
to
681a83d
Compare
lightclient
force-pushed
the
impl-eip-2718
branch
from
681a83d
to
7a22d84
Compare
* les: allow tx unindexing in les/4 light server mode * les: minor fixes * les: more small fixes * les: add meaningful constants for recentTxIndex handshake field
…ng (ethereum#22035) * eth/download/statesync : state hash sum optimized * go fmt with blank in imports * keccak read arg fix
During the snap and eth refactor, the net_version rpc call was falsely deprecated. This restores the net_version RPC handler as most eth2 nodes and other software depend on it.
* common,crypto: move fuzzers out of core * fuzzers: move vm fuzzer out from core * fuzzing: rework cover package logic * fuzzers: lint
The legacy dot-org URL was displaying a message about the repository having migrated to the dot-com service, which now covers open-source projects as well.
… tracers (ethereum#22038) * eth/tracers: share tx gas price with js tracer * eth/tracers: use `go generate` * eth/tracers: try with another version of go-bindata * eth/tracers: export txGas * eth, eth/tracers: pass intrinsic gas to js tracers eth/tracers: include tx gas in tracers usedGas eth/tracers: fix prestate tracer's sender balance eth/tracers: rm unnecessary import eth/tracers: pass intrinsicGas separately to tracer eth/tracers: fix tests broken by lack of txdata eth, eth/tracers: minor fix * eth/tracers: regenerate assets + unexport test-struct + add testcase * eth/tracers: simplify tests + make table-driven Co-authored-by: Guillaume Ballet <gballet@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se>
… to testchainconfig
This is still WIP
This renames the fields of the new tx data types to match the accessor names of Transaction.
This updates everything to use EIP2718Signer instead of EIP155Signer. To make this simpler next time, I have added two new API functions for creating signers: - LatestSigner is for places which have chain config available - LatestSignerForChainID is for places where only the chain ID is available
The signer doesn't accept all EIP-2718 transactions, only EIP-2930 access list transactions. This is why it is now called eip2930Signer. Also unexport this new signer type because it is not supposed to be used directly. I'd love to unexport EIP155Signer as well, but can't do that because it's been around for so long,
The EIP says: TransactionType is a positive unsigned 8-bit number between 0 and 0x7f that represents the type of the transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~