EIP-2718: Typed Transaction Envelope + EIP-2930

[lightclient]

Hi all, I'm working on implementing EIP-2718: Typed Transaction Envelope. As of ACD 92 it is considered EFI. It is a dependency for the following:

• YOLOv2 testnet
• EIP-1559
• EIP-2711
• EIP-2930
• EIP-2803

Given the amount of code that this PR will eventually update, it would help me a lot to get some feedback earlier on to make sure this is headed in a good direction. Please let me know if there is a better way to request feedback.

[lightclient]

I'm planning to update this to use the original Transaction struct + interface as txdata (had trouble encoding the interface version).

[holiman]

Thanks for starting to work on this. It's a bit hard to judge if the interfaces are 'right' without more concrete examples, so I was wondering if you'd also be interested in implementing the 2930 transaction type within the same PR?
Note, you wouldn't need to implement the actual handling of access lists, but use the concrete new transaction type to see if the abstraction model you have chosen is sufficient to accommodate it?

I was thinking of picking it up myself, but it seems like a bad idea for me to implement something that you've already gotten a good start on... ?

[holiman]

Regarding your concrete questions, I don't really have any good answers now, I think it will be easier to give feedback with more concrete types implemented.

[lightclient]

I was wondering if you'd also be interested in implementing the 2930 transaction type within the same PR?

Yep, I would be happy to.

[lightclient]

@holiman @fjl, do you prefer the tests for this PR to be written natively in geth, as part of retesteth, or both?

[holiman]

do you prefer the tests for this PR to be written natively in geth, as part of retesteth, or both?

We always want 'native' tests in the codebase. If there are other more high-level tests that's good too, but we don't want to rely on those only

[lightclient]

Hi @holiman, I implemented EIP-2930 using the EIP-2718 envelope. This PR is rebased against your EIP-2929 PR. For a simpler diff, I have a PR on my own repo against your branch.

[holiman]

I rebased this on top of access_lists.
I think it'll be easier to review this once that one is merged