Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: fix stale comment #2179

Merged
merged 1 commit into from
Mar 10, 2023
Merged

identify: fix stale comment #2179

merged 1 commit into from
Mar 10, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Mar 9, 2023

#2173 removed the requirement that swarm notifies identify before any new streams are started on a connection

@sukunrt
identify: fix stale comment
8da4748 
libp2p#2173 removed the requirement
that swarm notifies identify before any new streams are started on a
connection
MarcoPolo
MarcoPolo approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is still the case we get the notification before accepting streams, it isn't crucial like this comment makes it sound. So it makes sense to remove this comment.

Ty!

@MarcoPolo MarcoPolo merged commit ed96a64 into libp2p:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

@marten-seemann marten-seemann Awaiting requested review from marten-seemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukunrt @MarcoPolo