identify: Fix IdentifyWait when Connected events happen out of order #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
changed the title
marten-seemann
approved these changes
Mar 7, 2023
|
This fixes a lot of the flakiness in the autorelay tests. I'm having a much harder time reproducing some earlier flakes. Thanks @sukunrt :) |
|
Woohoo, this is great! Fewer flaky tests! |
sukunrt
added a commit
to sukunrt/go-libp2p
that referenced
this pull request
Mar 9, 2023
libp2p#2173 removed the requirement that swarm notifies identify before any new streams are started on a connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2163
Adds an
IsClosedmethod tonetwork.Conn