Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove github.com/pkg/errors from direct dependencies #2581

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Remove github.com/pkg/errors from direct dependencies #2581

merged 1 commit into from
Jun 21, 2022

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 21, 2022 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This removes the last missing piece and then cleans go.mod.

Which issue(s) this PR fixes:

Closes #2549

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Switched to golang native error wrapping.

@saschagrunert
Remove github.com/pkg/errors from direct dependencies
d139c02 
This removes the last missing piece and then cleans go.mod.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 21, 2022
@saschagrunert saschagrunert mentioned this pull request Jun 21, 2022
Closed
19 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Jun 21, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 21, 2022
@ameukam
Copy link
Member

ameukam commented Jun 21, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0da1c9f into kubernetes:master Jun 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 21, 2022
@saschagrunert saschagrunert deleted the pkg-errors branch June 21, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@mkorbi mkorbi Awaiting requested review from mkorbi

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

Replace github.com/pkg/errors dependency with native error wrapping
3 participants
@saschagrunert @k8s-ci-robot @ameukam